Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Global Metadata Validation Checks #105

Merged

Conversation

Alrobbertz
Copy link
Member

  • Adds immediate validation checks on required pieces of global metadata. These would throw harder-to-read errors later during derivation. Better practice now to raise the error as early as possible.

closes #101

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65ec6b1) 94.47% compared to head (033fda2) 94.28%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   94.47%   94.28%   -0.20%     
==========================================
  Files          10       10              
  Lines        1756     1767      +11     
==========================================
+ Hits         1659     1666       +7     
- Misses         97      101       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alrobbertz Alrobbertz marked this pull request as ready for review November 2, 2023 18:41
Copy link
Member

@dbarrous dbarrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two typos. Will approve after the suggestions are merged

hermes_core/timedata.py Outdated Show resolved Hide resolved
hermes_core/tests/test_timedata.py Outdated Show resolved Hide resolved
Co-authored-by: Damian Barrous Dume <damianbarrous@gmail.com>
Copy link
Member

@dbarrous dbarrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alrobbertz Alrobbertz merged commit a7315cb into HERMES-SOC:main Nov 15, 2023
14 checks passed
@Alrobbertz Alrobbertz deleted the 101-update-global-meta-derivations branch November 15, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make HermesData meta a required parameter or update derivations
2 participants