Convert Datetime to Astropy Time #107
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
+ Coverage 94.28% 94.47% +0.19%
==========================================
Files 10 10
Lines 1767 1757 -10
==========================================
- Hits 1666 1660 -6
+ Misses 101 97 -4 ☔ View full report in Codecov by Sentry. |
| @@ -1321,8 +1299,7 @@ def _get_generation_date(self, data): | |||
| """ | |||
| Function to get the date that the CDF was generated. | |||
| """ | |||
| day = datetime.date.today() | |||
| return datetime.datetime(day.year, day.month, day.day) | |||
| return Time.now().strftime("%Y-%m-%d") | |||
There was a problem hiding this comment.
Should further specify the date here in case we generate two CDF files in a single day?
There was a problem hiding this comment.
@ehsteve The previous implementation just included the date (no time) so I followed that paradigm. We would only have naming conflicts if the other portions of the name were also the same: instrument, start time, mode, data level...
I do not think we'll meet these conditions where all aspects are the same, but if you think we will, I can update to include a timestamp in addition to the date.
This PR converts use of the
datetimelibrary to use exclusivelyastropy.time.Timeobjects within the HERMES data container.datetimeobjects are still required for interactions with thespacepylibrary because spacepy does not have Astropy time support. However, this improves consistency within the data container itself so thedatetimelibrary is only used in the IO functionality needed to load and save CDFs with spacepy.closes #102