Updates to use Path rather than str #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarrous
approved these changes
May 28, 2024
There was a problem hiding this comment.
LGTM! Once this is merged we can re-run the eea tests in HERMES-SOC/hermes_eea#41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the HERMES Core functionality to consistently use
pathlib.Pathobjects for file paths when loading, saving, and validating CDF files. Previously these functions usedstrobjects, which goes against the HERMES best-practices. This PR aligns the functionality of the package with the best practices defined for the mission code development.This PR and HERMES-SOC/hermes_eea#41 are co-dependent so we need to decide which we want to complete first. My recommendation would be to complete this PR first.
I've manually tested the sdc_aws_processing_lambda, combining changes from both PRs , and successfully generated a CDF file.