New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using f-strings and log on import #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me! Definitely prefer this formatting over the .format()
, way easier to read and make sense of. Did notice two little nitpicks but other than that ✅
Also just noticed there a few merge conflicts, you might want to re-sync your branch with main or if you give me the go ahead I can resolve them for you ^ |
Co-authored-by: Damian Barrous Dume <damianbarrous@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 75.96% 76.07% +0.11%
==========================================
Files 5 5
Lines 208 209 +1
==========================================
+ Hits 158 159 +1
Misses 50 50
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This cleans up the code to use fstrings instead of the format syntax. fstrings make the code much cleaner. Also updated the code standards to say to use fstrings.
This also adds a log message on import to show the version number of the package on import. Useful for debugging purposes.
Addresses issues #27, #23.