Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix devcontainer config to use new vscode user #32

Merged
merged 2 commits into from Dec 7, 2022

Conversation

dbarrous
Copy link
Member

@dbarrous dbarrous commented Nov 22, 2022

This PR (will be very similar to the other 4), it helps address this issue: HERMES-SOC/hermes_eea#6

It sets the default user of the devcontainer to be the new vscode user that is introduced in this PR (Should be merged after this one is merged): HERMES-SOC/sdc_aws_base_docker_image#23

It also fixes a few path issues that were pointed out in the issue.

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #32 (7331868) into main (c68c37e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   76.19%   76.19%           
=======================================
  Files           5        5           
  Lines         210      210           
=======================================
  Hits          160      160           
  Misses         50       50           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ehsteve ehsteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out on my computer and it looks like it works.

@dbarrous dbarrous merged commit 653ad0b into HERMES-SOC:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants