Skip to content

Commit

Permalink
Change to pull from ECR public registry (#21)
Browse files Browse the repository at this point in the history
* Change to pull from ECR public registry

* Make requested changes (Add repo link)
  • Loading branch information
dbarrous committed Jul 7, 2022
1 parent 566fe8d commit c582a85
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 37 deletions.
14 changes: 0 additions & 14 deletions .devcontainer/Dockerfile

This file was deleted.

12 changes: 5 additions & 7 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
// https://github.com/microsoft/vscode-dev-containers/tree/v0.183.0/containers/python-3
{
"name": "Ubuntu 20.04 Python 3",
"build": {
"dockerfile": "Dockerfile",
"context": ".."
},
// Repo where this image's Dockerfile is maintained: https://github.com/HERMES-SOC/docker-lambda-base
"image": "public.ecr.aws/w5r9l1c8/swsoc-docker-lambda-base:latest",
"initializeCommand": "docker logout public.ecr.aws && docker pull public.ecr.aws/w5r9l1c8/swsoc-docker-lambda-base:latest",
// Set *default* container specific settings.json values on container create.
"settings": {
"python.pythonPath": "/usr/bin/python3",
Expand Down Expand Up @@ -43,12 +42,11 @@
"ms-python.python",
"ms-python.vscode-pylance",
"marklarah.pre-commit-vscode"
],
]
// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],
// Use 'postCreateCommand' to run commands after the container is created.
"postCreateCommand": "pip3 install -r .devcontainer/requirements.txt",
//"postCreateCommand": "bash -i -c 'pip3 install --user .[all]'",
// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
"remoteUser": "vscode"
// "remoteUser": "vscode"
}
16 changes: 0 additions & 16 deletions .devcontainer/requirements.txt

This file was deleted.

0 comments on commit c582a85

Please sign in to comment.