Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added process_file function #15

Merged
merged 17 commits into from
Jan 30, 2023
Merged

Added process_file function #15

merged 17 commits into from
Jan 30, 2023

Conversation

ehsteve
Copy link
Member

@ehsteve ehsteve commented Jan 25, 2023

Also added first draft of code to parse nemisis science packets. This depends on the issue in CCSDSPy being solved.

@ehsteve
Copy link
Member Author

ehsteve commented Jan 25, 2023

Once this is in good shape. I can make similar changes across all of the instrument packages.

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #15 (abaee2b) into main (df979b3) will increase coverage by 1.59%.
The diff coverage is 89.79%.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   89.47%   91.07%   +1.59%     
==========================================
  Files           3        4       +1     
  Lines          19       56      +37     
==========================================
+ Hits           17       51      +34     
- Misses          2        5       +3     
Impacted Files Coverage Δ
hermes_nemisis/calibration/calibration.py 90.19% <89.58%> (+3.52%) ⬆️
hermes_nemisis/io/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ehsteve
Copy link
Member Author

ehsteve commented Jan 26, 2023

The only thing failing is a small loss in coverage which should not stop this merge request. Is there a way to stop codecov from complaining on small losses to coverage?

@dbarrous
Copy link
Member

The only thing failing is a small loss in coverage which should not stop this merge request. Is there a way to stop codecov from complaining on small losses to coverage?

I've adjusted the threshold for it to fail only if there is a change that if it decreases coverage by 5%. It can be adjusted in the Global YAML file here: https://app.codecov.io/account/gh/HERMES-SOC/yaml/

@ehsteve
Copy link
Member Author

ehsteve commented Jan 26, 2023

Thanks @dbarrous!

@ehsteve ehsteve marked this pull request as ready for review January 26, 2023 20:37
Copy link
Member

@dbarrous dbarrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehsteve I just finished testing this on the processing lambda function and was able to successfully create files from l0 -> l1 -> ql. It looks like it's working great :) Once we get this merged I'll create a PR for the changes to the processing function to support it. I've also been able to reduce the amount of code needed with this new functionality in the processing function.

@ehsteve ehsteve merged commit 53a04b5 into HERMES-SOC:main Jan 30, 2023
@ehsteve ehsteve deleted the process_file branch January 30, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants