Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Instrument File Processing Functions #20

Closed
wants to merge 5 commits into from

Conversation

Alrobbertz
Copy link
Member

  • Separates input, calibration, and output into three distinct functions
  • Ensures calibration is done using the HermesData data container structure

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (c6090d6) 91.07% compared to head (8c73799) 79.03%.

Files Patch % Lines
hermes_nemisis/calibration/calibration.py 56.25% 7 Missing ⚠️
hermes_nemisis/io/file_tools.py 85.29% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #20       +/-   ##
===========================================
- Coverage   91.07%   79.03%   -12.04%     
===========================================
  Files           4        4               
  Lines          56       62        +6     
===========================================
- Hits           51       49        -2     
- Misses          5       13        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dbarrous dbarrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehsteve
Copy link
Member

ehsteve commented Jan 22, 2024

@Alrobbertz there is a conflict to resolve.

@Alrobbertz Alrobbertz closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants