Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrated new transforms module in the hexrd3 code base #8

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ovillellas
Copy link
Contributor

All the work for the new transforms module put inside the hexrd3 codebase.

As hexrd3 is not yet complete, I've added the new transforms module as "transforms".

The old transforms is renamed and appears as legacy_transforms. All calls I've found are redirected to legacy_transforms until they the new transforms can be integration-tested (herxd3 needs to be functional for that).

Structure-wise:

  • All �C code is placed under the extensions directory, isolated from the Python code. However,
    legacy transforms C code remains in the legacy-transforms directory.
  • At runtime, extensions will appear as "hexrd.extensions.". This follows
    what was already done for the legacy transforms.
  • tests for transforms are under a tests directory that is outside the source code for the package
    so that it is not included in installation. This is different from other tests that are physically
    close with what they test (the same directory).

@joelvbernier
Copy link
Member

@ovillellas We will revisit this soon!

@joelvbernier joelvbernier marked this pull request as draft March 16, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants