Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move driver graphics out of main package #10

Merged
merged 1 commit into from May 13, 2019
Merged

Move driver graphics out of main package #10

merged 1 commit into from May 13, 2019

Conversation

andydotxyz
Copy link
Contributor

Remove the pixelgl import from the main package.
This enables alternative graphical drivers.

@HFO4
Copy link
Owner

HFO4 commented May 11, 2019

I remember pixelgl requires to take over the main function.🤔 I
will check this in few days.

@andydotxyz
Copy link
Contributor Author

Yes, this patch does not change the thread it runs on, it just launches the pixelgl only if required. It moves the pixelgl runner to later in the code but still on the main thread. I tested this with an alternative (Fyne) graphics system that also requires starting from the main thread.

@HFO4 HFO4 merged commit 38cf886 into HFO4:master May 13, 2019
@andydotxyz andydotxyz deleted the drivergraphics branch May 13, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants