Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#155 Update reference sequence numbering diagram #156

Merged
merged 5 commits into from
Mar 19, 2024
Merged

#155 Update reference sequence numbering diagram #156

merged 5 commits into from
Mar 19, 2024

Conversation

reece
Copy link
Collaborator

@reece reece commented Mar 10, 2024

See #155

@reece reece linked an issue Mar 10, 2024 that may be closed by this pull request
Update reference sequence diagram #155
Closed
@reece reece marked this pull request as ready for review March 18, 2024 20:20
@reece
Copy link
Collaborator Author

reece commented Mar 18, 2024

Here's the sole change:
https://hgvs-nomenclature--156.org.readthedocs.build/156/background/numbering/#figure

Compare with
https://hgvs-nomenclature.org/background/numbering/#figure

@reece
Copy link
Collaborator Author

reece commented Mar 19, 2024 •
edited

Good catch @ahwagner !

Now:
image

And:
image

@reece reece requested a review from ahwagner March 19, 2024 03:41
ifokkema
ifokkema approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@ifokkema ifokkema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@reece
Copy link
Collaborator Author

reece commented Mar 19, 2024

@ahwagner : merge is waiting on your blessing since you requested changes

jfjlaros
jfjlaros approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@jfjlaros jfjlaros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

@jfjlaros jfjlaros merged commit 2b01339 into main Mar 19, 2024
1 check passed
@jfjlaros jfjlaros deleted the 155-update-reference-sequence-diagram branch March 19, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahwagner ahwagner ahwagner approved these changes

@jfjlaros jfjlaros jfjlaros approved these changes

@ifokkema ifokkema ifokkema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update reference sequence diagram
4 participants
@reece @ahwagner @jfjlaros @ifokkema