Fix get_edges() and linalg.incidence_matrix_by_order() #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linalg.incidence_matrix_by_order()
|
Hi, I have exposed |
|
Hi, thank you for your contribution! As of now, I'm still deciding what is the correct way to handle lin alg methods. As of now I prefer them to not be exposed. Can you roll point 1 back? Thank you!:) |
|
Hi, no problem at all, I enjoy working on this repo. I have rolled back point 1. |
|
Thanks, I'm merging the PR! I'm happy that you're enjoying the repo! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hg1.incidence_matrix_by_order(2)is now possible.)get_edges()had a bug where, while initializing a subhypergraph from a weighted hypergraph the weights were not being provided correctly. This commit fixes said issue.linalg.incidence_matrix_by_order()Please check and let me know if any edge cases are breaking. That can also help when writing tests for this module, which is my eventual plan. Thanks!