Null defaults in enums #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…over cases where there were no people loaded with times for the time tracking and thus the internal tracking container does not exist despite the policy for time tracking being on. In these cases, the data manger should get time tracking from the associated time when the associated property definition is created.
…cture have had updates to their unit tests to test this edge case.
bischoffz
pushed a commit
that referenced
this pull request
Feb 28, 2024
* Removed redundant precondition test * Improved addGroup unit test for AT_GroupsPluginData * Expanded test of PersonPropertyDataManager.getPersonPropertyTime to cover cases where there were no people loaded with times for the time tracking and thus the internal tracking container does not exist despite the policy for time tracking being on. In these cases, the data manger should get time tracking from the associated time when the associated property definition is created. * The EnumContainer now accepts null default values. All dependent structure have had updates to their unit tests to test this edge case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.