PersonProperties Event Filters Addition #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ties-event-filters
…ties-event-filters
…ties-event-filters
…HS/ASPR-8 into personproperties-event-filters
bischoffz
requested changes
Feb 10, 2023
There was a problem hiding this comment.
I went ahead and merged the latest dev in for you and fixed the resulting merge conflicts that occurred as a result of the other pull request going in. There are several things that need to be addressed. Get with me or Shawn if you need help figuring out how to solve them. I have commented on some of them, the other things will pop up as soon as you resolve the ones I commented on here.
gcm4/src/test/java/plugins/personproperties/datamanagers/AT_PersonPropertyDataManager.java
Outdated
Show resolved
Hide resolved
gcm4/src/test/java/plugins/personproperties/datamanagers/AT_PersonPropertyDataManager.java
Outdated
Show resolved
Hide resolved
gcm4/src/test/java/plugins/personproperties/datamanagers/AT_PersonPropertyDataManager.java
Outdated
Show resolved
Hide resolved
gcm4/src/test/java/plugins/personproperties/datamanagers/AT_PersonPropertyDataManager.java
Outdated
Show resolved
Hide resolved
gcm4/src/test/java/plugins/personproperties/datamanagers/AT_PersonPropertyDataManager.java
Outdated
Show resolved
Hide resolved
gcm4/src/test/java/plugins/personproperties/datamanagers/AT_PersonPropertyDataManager.java
Outdated
Show resolved
Hide resolved
gcm4/src/test/java/plugins/personproperties/datamanagers/AT_PersonPropertyDataManager.java
Outdated
Show resolved
Hide resolved
bischoffz
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.