-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ops 2239/refactor get response schema #2330
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of to_dict for serialization
…greements. Adjusted to use a map to more specific schemas instead of having one crowded base schema.
rajohnson90
changed the title
DRAFT: Ops 2239/refactor get response schema
Ops 2239/refactor get response schema
May 20, 2024
rajohnson90
changed the title
Ops 2239/refactor get response schema
DRAFT Ops 2239/refactor get response schema
May 20, 2024
Realized I did not map CANs in. I will need a bit more time to add CANs so I'm moving this back to draft status. |
4 tasks
rajohnson90
changed the title
DRAFT Ops 2239/refactor get response schema
Ops 2239/refactor get response schema
May 22, 2024
rajohnson90
added
tech-debt
Resolved technical debt (tooling, configuration, or workflow)
and removed
don't merge
labels
May 22, 2024
stevtek
approved these changes
May 22, 2024
johndeange
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Updated the GET Agreement and GET Agreements endpoints to use base marshmallow schemas in order to serialize Agreements before being returned by the API. We could further use marshmallow capabilities to exclude unneeded data and keep the Agreement object size smaller, but I don't have the knowledge of our codebase required to determine what data is currently considered 'unnecessary'.
Issue
Issue 2239
How to test
Definition of Done Checklist