Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Add transformations for the assistance listing tables #1746

Closed
chouinar opened this issue Apr 16, 2024 · 0 comments · Fixed by #1875
Closed

[Task]: Add transformations for the assistance listing tables #1746

chouinar opened this issue Apr 16, 2024 · 0 comments · Fixed by #1875
Assignees
Labels
project: grants.gov Grants.gov Modernization tickets

Comments

@chouinar
Copy link
Collaborator

Summary

Handles transforms for the assistance listing table

https://app.gitbook.com/o/cFcvhi6d0nlLyH2VzVgn/s/v1V0jIH7mb7Yb3jlNrgk/engineering/learnings/opportunity-endpoint-data-model#opportunity-assistance-listing

Acceptance criteria

No response

@chouinar chouinar added the project: grants.gov Grants.gov Modernization tickets label Apr 16, 2024
@acouch acouch removed the refinement label Apr 23, 2024
@chouinar chouinar self-assigned this Apr 29, 2024
chouinar added a commit that referenced this issue May 3, 2024
This is a follow-up to
#1794 - which it builds
upon.

## Summary
Fixes #1746

### Time to review: __10 mins__

## Changes proposed
Adds transformation logic for the assistance listing (formerly CFDA)
tables.

## Context for reviewers
The transformations are pretty uneventful, the only complexity is that
the legacy Oracle database doesn't have a foreign key between the
`TopportunityCfda` table and the `Topportunity` table and there are
~2300 orphaned cfda records that we wouldn't be able to import, so we
additionally need to validate that the opportunity exists when we try to
transform the data, and if not, we just mark it as "transformed" and do
nothing with it.

There is some basic work on relationships between the staging tables +
more factories for setting up the data which will be ongoing /
@jamesbursa is also looking into.

---------

Co-authored-by: nava-platform-bot <platform-admins@navapbc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: grants.gov Grants.gov Modernization tickets
Projects
Development

Successfully merging a pull request may close this issue.

4 participants