[Issue #1744] Setup staging tables for Oracle data load #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
requested review from
acouch,
aplybeah and
SammySteiner
as code owners
chouinar
commented
Apr 25, 2024
Comment on lines
25
to
26
| created_date: Mapped[datetime.datetime | None] | ||
| last_upd_date: Mapped[datetime.datetime | None] |
There was a problem hiding this comment.
@jamesbursa This was the only modification I made to the columns, these need to be nullable. Other tables already have these fields nullable, so this just follows the same pattern.
The last update date being null is expected, they only set it to null once it has at least one update. Create date being null seems like a bug, but I found 10 cases in the prod data where it happens
github-actions
bot
added
the
documentation
jamesbursa
previously approved these changes
Apr 25, 2024
api/src/db/foreign/forecast.py
Outdated
| import datetime | ||
|
|
||
| from sqlalchemy.orm import Mapped, mapped_column | ||
| import src.db.legacy_mixins.forecast_mixin as forecast_mixin |
There was a problem hiding this comment.
Can shorten to:
Suggested change
| import src.db.legacy_mixins.forecast_mixin as forecast_mixin | |
| from src.db.legacy_mixins import forecast_mixin |
jamesbursa
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1744
Time to review: 10 mins
Changes proposed
Setup staging tables for the data ingestion process from Oracle
Modified the foreign tables to instead pull in columns from a mixin (that we reuse for the staging tables)
Context for reviewers
I built this by literally copying the existing foreign tables, and fixing the class name/definitions. The column order should be unmodified, and the columns themselves unmodified (One exception is commented below).
Additional information
I setup a factory for the staging topportunity table (more will be added as needed) just to confirm we can interact with it. Can easily test by running
make consoleand then running commands likef.StagingTopportunityFactory(opportunity_id=100, already_transformed=True)