[Issue #1795]: Fix feature flag refresh bug #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylew1
requested review from
andycochran,
acouch and
SammySteiner
as code owners
rylew1
commented
Apr 26, 2024
| @@ -39,7 +39,8 @@ export function generateMetadata() { | |||
|
|
|||
| export default async function Search({ searchParams }: ServerPageProps) { | |||
| const ffManager = new FeatureFlagsManager(cookies()); | |||
| if (!ffManager.isFeatureEnabled("showSearchV0")) { | |||
|
|
|||
| if (ffManager.isFeatureDisabled("showSearchV0", searchParams)) { | |||
There was a problem hiding this comment.
switch this to isFeatureDisabled - reads a little better when the intent is to check if we should redirect to the NotFound page
acouch
approved these changes
Apr 29, 2024
| @@ -6,6 +6,7 @@ import { NextRequest, NextResponse } from "next/server"; | |||
|
|
|||
| import { CookiesStatic } from "js-cookie"; | |||
| import { ReadonlyRequestCookies } from "next/dist/server/web/spec-extension/adapters/request-cookies"; | |||
| import { ServerSideSearchParams } from "../types/searchRequestURLTypes"; | |||
There was a problem hiding this comment.
out of scope comment. the mixing of relative paths gave me pause. i created a ticket to address for the frontend: #1868 , so this is fine for now.
There was a problem hiding this comment.
Sure, we can take a look at making imports more consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1795
Time to review: 5 min
Changes proposed
isFeatureEnabledto have query params override the currently set cookie (which can become out of date)isFeatureDisabledContext
The feature flag is set from a Next middleware function in
FeatureFlagsManager. Unfortunately when this is set, it's not setting a value that's accessible to other code in the same request/response cycle (like the server component page) . The server component page has access tonext/headerscookies, but not from the ones set from the middleware function.So we can just pass the
SearchParamsthat the server component has into theisFeatureEnabled(andisFeatureDisabled) for now. Acknowledging that there might be multiple ways to do this.Screen.Recording.2024-04-26.at.3.33.48.PM.mov