[Issue #1686] add created_at, updated_at, and deleted_at columns to staging tables
#1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to staging tables
jamesbursa
requested review from
acouch,
aplybeah,
chouinar and
SammySteiner
as code owners
chouinar
reviewed
May 1, 2024
api/src/db/migrations/versions/2024_05_01_add_created_at_updated_at_and_deleted_.py
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
documentation
chouinar
previously approved these changes
May 1, 2024
| command.downgrade(alembic_cfg, revision) | ||
|
|
||
|
|
||
| def enable_query_logging() -> None: |
There was a problem hiding this comment.
Testing this, it ends up being very verbose. Is there a way we could make this configurable? Fine if its a follow-up, but locally I want to see just the alembic output, not this so much and now the logs are 3x as long
There was a problem hiding this comment.
The goal is that if there's ever a very slow migration, you can see which one it's currently processing. I'll make a follow up.
Co-authored-by: Michael Chouinard <46358556+chouinar@users.noreply.github.com>
chouinar
approved these changes
May 1, 2024
jamesbursa
deleted the
jamesbursa/1686-add-created-update-deleted-at-to-staging
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #1686 (separate for easier review)
Time to review: 2 mins
Changes proposed
created_at,updated_at, anddeleted_atcolumns to staging tablesContext for reviewers
These columns will provide helpful metadata for understanding or troubleshooting the load process.
The
created_atandupdated_atcolumns are set automatically by SQLAlchemy.For
deleted_at, I will update #1852 after this is merged.Additional information
Example from local testing:
