Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #1889] Updating GA4 for nextjs v2 #2002

Merged
merged 1 commit into from
May 13, 2024

Conversation

btabaska
Copy link
Collaborator

@btabaska btabaska commented May 13, 2024

Summary

Fixes #1889

Time to review: 5 mins

Changes proposed

Added manual "search" api call for GA4 on search bar click
Updated template to call GA4 correctly
Updated @next/third-party to canary to fix issues

Context for reviewers

Context in Eng Slack Thread

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

@btabaska btabaska merged commit bb423dc into main May 13, 2024
0 of 6 checks passed
@btabaska btabaska deleted the btabaska/1889-2-GA4-nextjs-integration branch May 13, 2024 19:52
Copy link

Coverage report for ./frontend

St.
Category Percentage Covered / Total
🟢 Statements
84.14% (+0.03% 🔼)
870/1034
🟡 Branches 65.01% 223/343
🟡 Functions 75.58% 164/217
🟢 Lines
84.18% (+0.03% 🔼)
809/961

Test suite run success

164 tests passing in 56 suites.

Report generated by 🧪jest coverage report action from 012d67f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add GA4 tracking for click-through-rate from search results to the opportunity listing
2 participants