-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refl-type is obsolete now #60
Comments
I installed the new FlightGear version and now I can verify the reflection issues. Do you know how to solve this? |
As I was involved in the whole shader thing, I think yes. The reflection cube map has a big influence, as well as the change in the code above. Another reason might be the rainbow and older pseudo-fresnel effect. Do you use the stable releases or the devel-releases (Nightly Builds)? |
My internet connection is crap so I use stable versions. The problem is fgdata, cloning the flightgear and simgear git repositories should not be a big deal. |
Just download this file and save it in ./ Shaders. Then we have a common base for this issue. |
OK, done. |
you should see a slight change with type 1 |
Still too much reflection on SkyWork livery if you look from behind. If you look from the side the reflection is great. |
@xcvb85 Reduce |
I set it to 0 and now it looks very nice 👍 |
Which is not realistic... 😄 |
Now I set fresnel-factor to 0.3 and refl_correction to -0.3 and now I'm happy with the result. What are your settings? |
Very similar: fresnel-factor 0.25, refl_correction -0.33. I think we can use your values if you want |
You will need: Nothing we can get without changing the renderer |
Sounds complicated. Nevertheless with correct fresnel-factor and refl_correction the results are not that bad either. 😀 |
No problem, my PC is powerful enough for maximum settings (Xeon E3-1231v3, RX480). |
Since Thorsten Renk pushed the final fix for the grey-reflection issue to FGData today, the refl-type is now obsolete on the livery-files. It can be removed for the upcoming FlightGear releases 2017.2.x
The text was updated successfully, but these errors were encountered: