Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refl-type is obsolete now #60

Open
HHS81 opened this issue Feb 24, 2017 · 17 comments
Open

Refl-type is obsolete now #60

HHS81 opened this issue Feb 24, 2017 · 17 comments
Assignees

Comments

@HHS81
Copy link
Owner

HHS81 commented Feb 24, 2017

Since Thorsten Renk pushed the final fix for the grey-reflection issue to FGData today, the refl-type is now obsolete on the livery-files. It can be removed for the upcoming FlightGear releases 2017.2.x

@xcvb85
Copy link
Collaborator

xcvb85 commented Feb 28, 2017

I installed the new FlightGear version and now I can verify the reflection issues. Do you know how to solve this?

@HHS81 HHS81 self-assigned this Feb 28, 2017
@HHS81
Copy link
Owner Author

HHS81 commented Feb 28, 2017

Do you know how to solve this?

As I was involved in the whole shader thing, I think yes.
wiki explanation
FGData Commit log

The reflection cube map has a big influence, as well as the change in the code above. Another reason might be the rainbow and older pseudo-fresnel effect.
I have some good results on the EC 135 P2 here on my system, I might apply this to the Dornier 328 as well soon.

Do you use the stable releases or the devel-releases (Nightly Builds)?

@xcvb85
Copy link
Collaborator

xcvb85 commented Feb 28, 2017

My internet connection is crap so I use stable versions. The problem is fgdata, cloning the flightgear and simgear git repositories should not be a big deal.

@HHS81
Copy link
Owner Author

HHS81 commented Feb 28, 2017

Just download this file and save it in ./ Shaders.

Then we have a common base for this issue.

@xcvb85
Copy link
Collaborator

xcvb85 commented Feb 28, 2017

OK, done.

@HHS81
Copy link
Owner Author

HHS81 commented Feb 28, 2017

you should see a slight change with type 1

@xcvb85
Copy link
Collaborator

xcvb85 commented Feb 28, 2017

Still too much reflection on SkyWork livery if you look from behind. If you look from the side the reflection is great.

@HHS81
Copy link
Owner Author

HHS81 commented Feb 28, 2017

@xcvb85 Reduce sim/rendering/fresnel-factor
For my eyes it is a bit too much from the side.

@xcvb85
Copy link
Collaborator

xcvb85 commented Feb 28, 2017

I set it to 0 and now it looks very nice 👍

@HHS81
Copy link
Owner Author

HHS81 commented Feb 28, 2017

Which is not realistic... 😄
Every material in the world has fresnel effect.

@xcvb85
Copy link
Collaborator

xcvb85 commented Feb 28, 2017

Now I set fresnel-factor to 0.3 and refl_correction to -0.3 and now I'm happy with the result. What are your settings?

@HHS81
Copy link
Owner Author

HHS81 commented Feb 28, 2017

Very similar: fresnel-factor 0.25, refl_correction -0.33. I think we can use your values if you want

@xcvb85
Copy link
Collaborator

xcvb85 commented Feb 28, 2017

I wonder what you need to do to get to a result like this:

xplane

I could imagine that you also need to adjust the hardness material factor in blender.

@HHS81
Copy link
Owner Author

HHS81 commented Feb 28, 2017

You will need:
HDR rendering
PBR-rendering
realtime reflections, shadows, lights
blinn-phong shading

Nothing we can get without changing the renderer

@xcvb85
Copy link
Collaborator

xcvb85 commented Feb 28, 2017

Sounds complicated. Nevertheless with correct fresnel-factor and refl_correction the results are not that bad either. 😀

@HHS81
Copy link
Owner Author

HHS81 commented Feb 28, 2017

And of course a very powerfull GPU!

This is what I got so far on the EC 135 P2:
fgfs-screen-018
fgfs-screen-019

This with your settings on the 328:
fgfs-screen-020
fgfs-screen-021

And this with Cessna 182 S:
fgfs-screen-022
fgfs-screen-023

@xcvb85
Copy link
Collaborator

xcvb85 commented Mar 1, 2017

No problem, my PC is powerful enough for maximum settings (Xeon E3-1231v3, RX480).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants