Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Update Broadcast Modal Description Population and Refactor form for Styling Consistency #1061

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

shivamgaur99
Copy link
Contributor

@shivamgaur99 shivamgaur99 commented Jun 20, 2024

Closes: #1045

Refactor update broadcast functionality to handle approval status and ensure style consistency

  • Modify update logic to correctly handle both approved and non-approved broadcast items.
  • Refactor form components to maintain consistent styling between create and update interfaces.
  • Ensure SunEditor content population and styling options align across broadcast editing workflows.

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

image

@auto-assign auto-assign bot requested a review from Kajol-Kumari June 20, 2024 12:13
@shivamgaur99
Copy link
Contributor Author

@Kajol-Kumari could you please review the changes?

Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivamgaur99 i can see a lot of un-necessary changes in this pr, please remove all the redundant changes and keep the folder structure same i.e Carousel/Edit

@shivamgaur99
Copy link
Contributor Author

shivamgaur99 commented Jun 21, 2024

@Kajol-Kumari Changes done please review, i thought edit folder should be in admin folder thats why earlier i put it into manage broadcast folder

@shivamgaur99
Copy link
Contributor Author

@Kajol-Kumari could you please check ?

Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivamgaur99

  1. The earlier change included the classes for dark and light mode which has been completely removed in this pr
  2. After successful update the toast message is saying successfully approved which is wrong, it should have been successfully updated instead.

@shivamgaur99
Copy link
Contributor Author

  1. The earlier change included the classes for dark and light mode which has been completely removed in this pr
  2. After successful update the toast message is saying successfully approved which is wrong, it should have been successfully updated instead.

@Kajol-Kumari both changes done

Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivamgaur99 the dark and light mode seems to be messed up in this pr, check the https://deploy-preview-1061--hitk-tech-community.netlify.app/ and compare it with https://hitk-tech-community.netlify.app/

@shivamgaur99
Copy link
Contributor Author

Hi @Kajol-Kumari its working fine can you check it again and please send ss if you are seeing any different
image
image

@Kajol-Kumari
Copy link
Member

Screenshot 2024-06-25 at 1 16 27 PM Screenshot 2024-06-25 at 1 16 52 PM

Check these 2 screenshots, how is the light mode your preview different from actual website's preview?

@shivamgaur99
Copy link
Contributor Author

i check more than 10 times by switching dark mode and light mode its showing same

@shivamgaur99
Copy link
Contributor Author

image
image
please look

@shivamgaur99
Copy link
Contributor Author

image

Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes doesn't seem to impact other pages ui but not sure why deploy preview is misbehaving, approving the pr for now

@Kajol-Kumari Kajol-Kumari added level1 Wiki or Major Documentation work. gssoc GSSoC'24 Label labels Jun 25, 2024
@Kajol-Kumari Kajol-Kumari merged commit 223ed8a into HITK-TECH-Community:main Jun 25, 2024
7 checks passed
@shivamgaur99
Copy link
Contributor Author

changes doesn't seem to impact other pages ui but not sure why deploy preview is misbehaving, approving the pr for now

thank you so much

@Kajol-Kumari
Copy link
Member

reverted the pr as merging this actually messed up the dark and light mode theme

@shivamgaur99
Copy link
Contributor Author

@Kajol-Kumari Can you tell me why its happening, while i have'nt change others file, may be after some times it will okay

@Kajol-Kumari
Copy link
Member

multiple reason can add to it

  1. Your forked branch is outdated
  2. the props that you passed is getting passed by reference
  3. any un-intenteded change which will required debugging. And i already checked by merging, something is definately off in the pr which disturbed the ui of whole website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC'24 Label level1 Wiki or Major Documentation work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Update Broadcast Functionality Not Working
2 participants