Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api to delete resource of a given id and delete all resource older than 2months using cron job #751

Merged
merged 4 commits into from
Mar 13, 2022

Conversation

Aman16-ai
Copy link
Contributor

Delete a resource of given id and delete all resources older than 2 months using cron job

Closes: #738

Proposed changes

Brief description of what is fixed or changed

Types of changes

Put an x in the boxes that apply

  • [ x] Bugfix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • [x ] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • [x ] My changes does not break the current system and it passes all the current test cases.

Screenshots

Screenshot (720)
Screenshot (721)
Screenshot (722)
Screenshot (723)
Screenshot (724)

Please attach the screenshots of the changes made in case of change in user interface

Other information

Any other information that is important to this pull request

Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need another api which will take the resource_id delete that particular resource under this issue. Please add that as well.

@Aman16-ai
Copy link
Contributor Author

We need another api which will take the resource_id delete that particular resource under this issue. Please add that as well.

I have already implemented it. Please see my commits

@Kajol-Kumari
Copy link
Member

Hey @Aman16-ai Yeah, I can see both the apis. Could you please add the tests for both of them as well. Then I would give the final review after testing it.

@Aman16-ai
Copy link
Contributor Author

Hey @Aman16-ai Yeah, I can see both the apis. Could you please add the tests for both of them as well. Then I would give the final review after testing it.

Ok I'll add the tests.

@Aman16-ai
Copy link
Contributor Author

Added test for delete resources
Screenshot (725)
Screenshot (726)
Screenshot (727)

.

Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Aman16-ai Can you please resolve the conflict by pulling latest changes from main branch so that I can merge it?

@Kajol-Kumari Kajol-Kumari added level3 New features, major bug fixing. GSSoC22 Identifier for GirlScript Summer of Code sprint labels Mar 12, 2022
@Kajol-Kumari Kajol-Kumari merged commit 51ef879 into HITK-TECH-Community:main Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSSoC22 Identifier for GirlScript Summer of Code sprint level3 New features, major bug fixing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backend] Delete API for resource Data
2 participants