-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api to delete resource of a given id and delete all resource older than 2months using cron job #751
Api to delete resource of a given id and delete all resource older than 2months using cron job #751
Conversation
…o delete all resource older than 2 months
bf8f8a5
to
e8e0591
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need another api which will take the resource_id
delete that particular resource under this issue. Please add that as well.
I have already implemented it. Please see my commits |
Hey @Aman16-ai Yeah, I can see both the apis. Could you please add the tests for both of them as well. Then I would give the final review after testing it. |
Ok I'll add the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@Aman16-ai Can you please resolve the conflict by pulling latest changes from main
branch so that I can merge it?
Delete a resource of given id and delete all resources older than 2 months using cron job
Closes: #738
Proposed changes
Brief description of what is fixed or changed
Types of changes
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that applyScreenshots
Please attach the screenshots of the changes made in case of change in user interface
Other information
Any other information that is important to this pull request