Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi ticket typo fixes #182

Closed
wants to merge 7 commits into from
Closed

Multi ticket typo fixes #182

wants to merge 7 commits into from

Conversation

karbates
Copy link
Collaborator

  • FHIR-33525: Swapped CDC link on COVID-19 for WHO link in Scope section of index.md
  • FHIR-33529: Fixed typo, from "steam" to "stream" on contact.md
  • FHIR-33597: Swapped colon for period after "US profiles of Patient" and added "to" after two instances of "SHALL conform" in patient.md
  • FHIR-33598: Changed [] to () around VaccineTypeSNOMED so they render as a link in vaccination.md

@karbates karbates requested a review from masnick October 29, 2021 20:18
@p9g
Copy link
Collaborator

p9g commented Nov 3, 2021

The fix for FHIR-33598 does not work. See https://build.fhir.org/ig/HL7/fhir-shc-vaccination-ig/branches/multi-ticket-typo-fixes/vaccination.html
This is related to https://github.com/HL7/fhir-shc-vaccination-ig/blob/master/examples/byCodeSystem/README.md that has a column for Value Set which has terms like VaccineTypeSNOMED which are not used in the IG.

@@ -47,7 +47,7 @@ Implementers SHALL use at least one of the following code systems for identifyin
Some additional information about the table above:

* A **code system** defines a set of "codes" and their mappings onto specific meanings. For example, the [CVX code system][CVX] includes the code `207`, which is mapped to the meaning "COVID-19, mRNA, LNP-S, PF, 100 mcg/0.5 mL dose". Using a code system helps to ensure implementers represent a given concept in a consistent way that other implementers can understand.
* A **value set** defines a group of codes that can be used within a specific element. For example, we define a [value set of SNOMED-CT codes for vaccine products][VaccineTypeSNOMED] for use in the `vaccineCode` element. FHIR allows an element to be "bound" to a value set, meaning that the contents of that element must come from the value set (for a "[required binding][binding]") or should come form the value set (for a "[preferred binding][binding]").
* A **value set** defines a group of codes that can be used within a specific element. For example, we define a [value set of SNOMED-CT codes for vaccine products](VaccineTypeSNOMED) for use in the `vaccineCode` element. FHIR allows an element to be "bound" to a value set, meaning that the contents of that element must come from the value set (for a "[required binding][binding]") or should come form the value set (for a "[preferred binding][binding]").
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(VaccineTypeSNOMED) does not work.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p9g
Copy link
Collaborator

p9g commented Dec 30, 2021

#192 has applied some of these same changes

@masnick
Copy link
Collaborator

masnick commented Dec 31, 2021

Covered by #192

@masnick masnick closed this Dec 31, 2021
@masnick masnick deleted the multi-ticket-typo-fixes branch December 31, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants