Biomarkers #76
Merged
Biomarkers #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update general page and biomarker profile with additional documentation. Fix profile id for biomarker. Add slice on GenomicsReport and GenomicImplication.
sirkyp
requested review from
bheale,
patrick-werner,
James-R-Jones and
rhdolin
|
@sirkyp I have a few minor feedback items from Jamie, that I was going to add into the branch sometime today or tomorrow. |
|
Thanks @rhdolin - None of those changes look to impact the proposed disposition, but let me know if you think differently (meaning in theory we could still vote on the JIRA while finalizing this branch/PR). |
sirkyp
requested review from
mlterryMitre-zz
and removed request for
mlterryMitre-zz
(1) hyperlinks for methods used in molecular biomarker ontology; (2) mark molecular biomarker ontology code system as experimental; (3) update examples in cancer bundles
|
Thanks @sirkyp , I've incorporated all the changes. There is no outstanding comments left to resolve that I'm aware of. |
sirkyp
commented
Aug 28, 2023
input/fsh/CGCodeSystem.fsh
Outdated
| * ^content = #complete | ||
| * ^version = "1.0.0" | ||
| * ^caseSensitive = true | ||
| * ^experimental = false |
There was a problem hiding this comment.
@rhdolin - You can set this to 'true' to indicate this CodeSystem is experimental.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FHIR-28943