[judge-d-24] code polishing

DONE: * improved endpoint documentation * test code indented and given section removed from ContractsControllerIT
HLTech · Jul 9, 2019 · 58b4716 · 58b4716
1 parent 2c1098f
commit 58b4716
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/...-server/src/main/java/dev/hltech/dredd/interfaces/rest/contracts/ContractsController.java b/...-server/src/main/java/dev/hltech/dredd/interfaces/rest/contracts/ContractsController.java
@@ -57,7 +57,7 @@ public List<String> getAvailableServiceNames() {
     }
 
     @GetMapping(value = "/contracts", produces = MediaType.APPLICATION_JSON_VALUE)
-    @ApiOperation(value = "Get contracts registered", nickname = "get names of services")
+    @ApiOperation(value = "Get registered contracts", nickname = "get names of services")
     @ApiResponses(value = {
         @ApiResponse(code = 302, message = "Found")
     })

diff --git a/...r/src/test/groovy/dev/hltech/dredd/interfaces/rest/contracts/ContractsControllerIT.groovy b/...r/src/test/groovy/dev/hltech/dredd/interfaces/rest/contracts/ContractsControllerIT.groovy
@@ -88,12 +88,11 @@ class ContractsControllerIT extends Specification {
             objectMapper.readValue(response.getContentAsString(), new TypeReference<List<String>>() {})
     }
 
-    def 'should calling /contracts should redirect to /contracts/services to improve api discovery'() {
-        given:
+    def 'should calling /contracts redirect to /contracts/services to improve api discovery'() {
         when:
-        def response = mockMvc.perform(
-            get('/contracts')
-        ).andReturn().getResponse()
+            def response = mockMvc.perform(
+                get('/contracts')
+            ).andReturn().getResponse()
         then:
             response.getStatus() == 302
             response.getRedirectedUrl() == "contracts/services"