Correct handling of multiple spaces in one environment in get request #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlodarcp
reviewed
Feb 11, 2021
| @@ -54,6 +54,35 @@ class JPAEnvironmentRepositoryIT extends Specification { | |||
| } | |||
| } | |||
|
|
|||
| def 'should overwrite what was persisted before - one environment with multiple spaces'() { | |||
There was a problem hiding this comment.
According to test name it should check if persist method overwrite previous environment state so there is missing persist call in given section (look for test above)
There was a problem hiding this comment.
wrong test name - will fix it
wlodarcp
approved these changes
Feb 11, 2021
| def thirdSpace = new Space('def', [new ServiceId('serviceName5', 'serviceVersion5')] as Set) | ||
|
|
||
| and: | ||
| def environment = new Environment('environmentName', [firstSpace, secondSpace, thirdSpace] as Set) |
There was a problem hiding this comment.
Minor - formatting - missing tabs
There was a problem hiding this comment.
sometimes we have it without indent, sometimes with. We would need to address this globally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.