Mime type for contracts #39
Conversation
Felipe444
force-pushed
the
mime-type-for-contracts
branch
from
d9d0876
to
c7bf677
Compare
Pull Request Test Coverage Report for Build 120
💛 - Coveralls |
| form.getCapabilities(), | ||
| form.getExpectations() | ||
| map(form.getCapabilities()), | ||
| form.getExpectations().entrySet().stream() |
There was a problem hiding this comment.
could you please extract this to method? it's not easy to understand what's happening
There was a problem hiding this comment.
What was my initial plan was to migrate to the final approach ant then get rid of any non-domain logic in ServiceContracts. For now we have there for example mapping from incoming data which binds us to non-domain logic.
If you really want it, I can do the final refactor now, but it would require to refactor duplicated code as well.
What do you think?
| provider, | ||
| version, | ||
| mapToEntity(form.getCapabilities()), | ||
| form.getExpectations().entrySet().stream() |
There was a problem hiding this comment.
could you please extract this to method?
There was a problem hiding this comment.
What was my initial plan was to migrate to the final approach ant then get rid of any non-domain logic in ServiceContracts. For now we have there for example mapping from incoming data which binds us to non-domain logic.
If you really want it, I can do the final refactor now, but it would require to refactor duplicated code as well.
What do you think?
| @@ -54,7 +85,7 @@ public ServiceContractsDto create(@PathVariable(name = "provider") String provid | |||
| } | |||
|
|
|||
| @GetMapping(value = "/contracts/{serviceName}", produces = MediaType.APPLICATION_JSON_VALUE) | |||
| @ApiOperation(value = "Get versions of a service with registered contracts", nickname = "get versions of a service") | |||
| @ApiOperation(value = "Get versions of a service with registered contracts", nickname = "create versions of a service") | |||
There was a problem hiding this comment.
revert this get -> create
| ) | ||
| )); | ||
| } | ||
|
|
||
| @GetMapping(value = "/contracts", produces = MediaType.APPLICATION_JSON_VALUE) | ||
| @ApiOperation(value = "Get names of services with registered contracts", nickname = "get names of services") | ||
| @ApiOperation(value = "Get names of services with registered contracts", nickname = "create names of services") |
| @GetMapping(value = "/contracts/{provider}/{version:.+}", produces = MediaType.APPLICATION_JSON_VALUE) | ||
| @ApiOperation(value = "Register contracts for a version of a service", nickname = "register contracts") | ||
| @ApiOperation(value = "Get contracts for a version of a service", nickname = "register contracts") |
There was a problem hiding this comment.
is it really registerting contracts? (nickname)
| dto.setName(serviceContracts.getName()); | ||
| dto.setVersion(serviceContracts.getVersion()); | ||
| @GetMapping(value = "/new/contracts/{provider}/{version:.+}", produces = MediaType.APPLICATION_JSON_VALUE) | ||
| @ApiOperation(value = "Get contracts for a version of a service", nickname = "register contracts") |
There was a problem hiding this comment.
again, is it registering contracts?
| @ApiResponse(code = 200, message = "Success", response = ServiceContractsDto.class), | ||
| @ApiResponse(code = 400, message = "Bad Request"), | ||
| @ApiResponse(code = 500, message = "Failure")}) | ||
| public NewServiceContractsDto newGet(@PathVariable(name = "provider") String provider, @PathVariable(name = "version") String version) { |
There was a problem hiding this comment.
not the best name for any method
| @ApiResponses(value = { | ||
| @ApiResponse(code = 200, message = "Success", response = ServiceContractsDto.class), | ||
| @ApiResponse(code = 400, message = "Bad Request"), | ||
| @ApiResponse(code = 500, message = "Failure")}) | ||
| public ServiceContractsDto create(@PathVariable(name = "provider") String provider, @PathVariable(name = "version") String version) { | ||
| public ServiceContractsDto get(@PathVariable(name = "provider") String provider, @PathVariable(name = "version") String version) { |
There was a problem hiding this comment.
getContractsForServiceInVersion?
|
|
||
| private Map<String, Map<String, NewServiceContractsDto.ContractDto>> mapExpectationsToDto(Map<ServiceContracts.ProviderProtocol, ServiceContracts.Contract> expectations) { | ||
| HashMap<String, Map<String, NewServiceContractsDto.ContractDto>> result = newHashMap(); | ||
| for (Map.Entry<ServiceContracts.ProviderProtocol, ServiceContracts.Contract> e : expectations.entrySet()) { |
There was a problem hiding this comment.
this loop is pretty complicated, is there any way to make it look easier?
There was a problem hiding this comment.
at least extract method with a name that will explain this logic
No description provided.