[judge-d-24] renamed endpoint /contracts to /contracts/services #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit ae2eb5a)
Felipe444
requested changes
Jul 8, 2019
| @@ -56,6 +56,16 @@ public ServiceContractsDto create(@PathVariable(name = "provider") String provid | |||
| return serviceContractsRepository.getServiceNames(); | |||
| } | |||
|
|
|||
| @GetMapping(value = "/contracts", produces = MediaType.APPLICATION_JSON_VALUE) | |||
| @ApiOperation(value = "Get contracts registered", nickname = "get names of services") | |||
There was a problem hiding this comment.
Get registered contracts
| def 'should calling /contracts should redirect to /contracts/services to improve api discovery'() { | ||
| given: | ||
| when: | ||
| def response = mockMvc.perform( |
...rver/src/test/groovy/dev/hltech/dredd/interfaces/rest/contracts/ContractsControllerIT.groovy
Outdated
Show resolved
Hide resolved
DONE: * improved endpoint documentation * test code indented and given section removed from ContractsControllerIT
Felipe444
approved these changes
Jul 9, 2019
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to increase user experience when working with API I have changed its structure. It is first part of changes towards /contracts/services/{service-name}/versions/{version}