add capability of assessing the impact of set of services on given env #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felipe444
requested changes
Dec 2, 2019
| @@ -36,9 +46,40 @@ public JudgeD(EnvironmentRepository environmentRepository, ServiceContractsRepos | |||
| return getValidatorResult(validatedService, environmentContracts, validator); | |||
| } | |||
|
|
|||
| public <C, E> Map<ServiceVersion, EnvironmentValidatorResult> validatedServicesAgainstEnvironment( | |||
There was a problem hiding this comment.
Maybe better method name
| .collect(toList()); | ||
|
|
||
| // replace environment contracts with validated ones | ||
| validatedContracts.forEach(validatedContract -> { |
| @@ -36,9 +46,40 @@ public JudgeD(EnvironmentRepository environmentRepository, ServiceContractsRepos | |||
| return getValidatorResult(validatedService, environmentContracts, validator); | |||
| } | |||
|
|
|||
| public <C, E> Map<ServiceVersion, EnvironmentValidatorResult> validatedServicesAgainstEnvironment( | |||
| List<ServiceContracts> validatedContracts, | |||
| String env, | |||
There was a problem hiding this comment.
Here we forfeit possiblity of testing external environments. I think that batch should allow to include external environment (i.e. multiple environments) like in another endpoint (above)
There was a problem hiding this comment.
ok, will do it in another iteration.
| @@ -25,7 +31,11 @@ public JudgeD(EnvironmentRepository environmentRepository, ServiceContractsRepos | |||
| this.serviceContractsRepository = serviceContractsRepository; | |||
| } | |||
|
|
|||
| public <C, E> EnvironmentValidatorResult validateServiceAgainstEnvironments(ServiceContracts validatedService, List<String> environments, InterfaceContractValidator<C, E> validator) { | |||
| public <C, E> EnvironmentValidatorResult validateServiceAgainstEnvironments( | |||
| ServiceContracts validatedService, | |||
| import org.springframework.web.bind.annotation.ResponseStatus; | ||
|
|
||
| @ResponseStatus(value = HttpStatus.BAD_REQUEST) | ||
| public class RequestValidationException extends RuntimeException { |
There was a problem hiding this comment.
We should use it in another endpoints to remain consistent
| import org.springframework.http.MediaType | ||
| import spock.lang.Specification | ||
|
|
||
| import static dev.hltech.dredd.domain.contracts.ServiceContracts.* |
Felipe444
approved these changes
Dec 2, 2019
|
Please add all last changes to readme so that it is clear what we can do in Judged |
Pull Request Test Coverage Report for Build 368
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.