fix(types): set compatibility with puppeteer v10

resolve #33
HLTech · Jun 22, 2021 · 45909b9 · 45909b9
1 parent d3adbbd
commit 45909b9
Show file tree

Hide file tree

Showing 4 changed files with 58 additions and 39 deletions.
diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
@@ -31,6 +31,10 @@ jobs:
                       version: '7'
                     - library: 'puppeteer'
                       version: '8'
+                    - library: 'puppeteer'
+                      version: '9'
+                    - library: 'puppeteer'
+                      version: '10'
                     - library: 'playwright'
                       version: '1.10'
         steps:

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -35,7 +35,7 @@
         "playwright": "^1.10.0",
         "prettier": "^2.0.5",
         "pretty-quick": "^1.10.0",
-        "puppeteer": "^8.0.0",
+        "puppeteer": "^10.0.0",
         "semantic-release": "^17.0.7",
         "ts-jest": "^24.0.1",
         "typescript": "^3.8.3"

diff --git a/src/controllers/PuppeteerController.ts b/src/controllers/PuppeteerController.ts
@@ -73,7 +73,7 @@ export interface PuppeteerRequest {
         url(): string;
     } | null;
     headers(): Record<string, string>;
-    method(): 'GET' | 'POST' | 'PATCH' | 'PUT' | 'DELETE' | 'OPTIONS';
+    method(): string;
     postData(): string | undefined;
     resourceType():
         | 'document'