Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

使用 ByteArrayOutputBuffer 替代 ByteArrayOutputStream #2873

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Glavo
Copy link
Member

@Glavo Glavo commented Mar 1, 2024

本 PR 中创建了一个新的工具类 ByteArrayOutputBuffer 用于替代 ByteArrayOutputStream

相比原始的 ByteArrayOutputStreamByteArrayOutputBuffer 新增以下功能:

  • 能够直接利用内部数组从 InputStream 中读取数据,避免创建额外的临时数组和二次数据拷贝;
  • 公开内部数组,允许在已知安全的情况下直接复用该数组。

@Glavo Glavo requested a review from burningtnt March 1, 2024 19:26
@burningtnt
Copy link
Member

去掉无效的拷贝操作后,对性能有多少提升?

目前我脑测想到的是 HMCL 长时间运行后(即 Logging 里存了一堆 Log),此时再导出日志时的表现……

@Glavo
Copy link
Member Author

Glavo commented Mar 23, 2024

去掉无效的拷贝操作后,对性能有多少提升?

目前我脑测想到的是 HMCL 长时间运行后(即 Logging 里存了一堆 Log),此时再导出日志时的表现……

相较于 IO 来说,内存拷贝的性能开销基本可以忽略,本 PR 主要目的是减少内存分配。

我计划在 HMCLauncher 中将默认堆内存调整为 1G 或者更小,优化内存分配可以减少 GC 带来卡顿以及 OOM 的风险。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants