-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include values in log messages #24
Conversation
FYI, this is being blocked by HMIProject/open62541-sys#9 for proper |
You can test the output with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By enclosing the invocations of printf()
in a loop
the code might become more compact and the closure would not be needed. But let's leave it as is. Works and the code is readable.
Ouch:
|
The loop would ensure that the code paths are shared to prevent one-off errors like this. |
Description
This makes sure to include values when printing out log messages. This is done by passing the format string with variadic arguments to
vsnprintf()
to handle all the formatting.Fixes #22