Allow timeout to be specified over the outgoing http connection #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,7 +36,7 @@ _.extend(Model.prototype, { | |||
|
|
|||
| reqConf.headers = _.extend({ | |||
| 'Content-Type': 'application/json', | |||
| 'Content-Length': data.length | |||
| 'Content-Length': Buffer.byteLength(data) | |||
There was a problem hiding this comment.
Is this related to the timeout?
There was a problem hiding this comment.
Ah No, this should be in a separate pull request
HughePaul
force-pushed
the
feature/connection-timeout
branch
from
c0768c4
to
e8e9f8b
Compare
…. returns an ETIMEDOUT error through the callbacks
HughePaul
force-pushed
the
feature/connection-timeout
branch
from
e8e9f8b
to
b65f8df
Compare
|
This looks good. @JoeChapman @easternbloc @daniel-ac-martin what do you think? |
|
LGTM - sorry I didn't see the @ mention before! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specified with timeout as an option to the model constructor or timeout as an option to a http action (save, fetch, delete) but this may get filtered out by url().
Returns an ETIMEDOUT error through the callbacks on timeout.