replace http.request with the request library to be able to use proxies #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HughePaul
force-pushed
the
feature/request-proxy
branch
from
45e62c0
to
7bf183e
Compare
|
Looking. |
|
LGTM. |
HughePaul
force-pushed
the
feature/request-proxy
branch
from
7bf183e
to
6da360e
Compare
| } | ||
| if (typeof callback === 'function') { | ||
| callback(err, data, responseTime); | ||
| } | ||
| }.bind(this); | ||
|
|
||
| var request = protocol.request(settings, function (response) { | ||
| Model._request(settings, function (e, response) { | ||
| if (e) { |
There was a problem hiding this comment.
e === event? Longhand is easier to identify
There was a problem hiding this comment.
BTW, I know it's error. Devils advocate
There was a problem hiding this comment.
fair comment, updated to err, across the module
HughePaul
force-pushed
the
feature/request-proxy
branch
from
6da360e
to
d51a3cb
Compare
|
hmpo-model@0.7.0 published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added request module to enable proxies specified by environment variables:
HTTP_PROXY and HTTPS_PROXY