Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure setuptools.setup() with setup.cfg #39

Merged
merged 3 commits into from Nov 18, 2018
Merged

Configure setuptools.setup() with setup.cfg #39

merged 3 commits into from Nov 18, 2018

Conversation

skirpichev
Copy link
Contributor

This also fixes warnings for recent pytest.

Some side notes:

  • line endings are inconsistent across the project (sometimes dos, sometimes unix). Should we fix this?
  • requirements.txt looks to be redundant and is inconsistent c.f. setup.py info. I suggest removing this file.
  • most of your dependencies specify not just lower bound for versions, but upper bound too (e.g. pytest>=3.0,<4.0). I'm not sure if this does make sense for a development version, unless you know that some dependency was broken in a new version.

see
https://setuptools.readthedocs.io/en/latest/setuptools.html#configuring-setup-using-setup-cfg-files

Also this commit expands some metadata, e.g. classifiers and
project_urls.  Testing requirements are specified with "tests" extras.
Other development requirements are tracked with "develop" extras.

References to extras are supported in tests_require since setuptools
v36.7.0, hence additional entry in setup_requires.
    With v3.10.0 I got:
        tests/test_matching.py:865
          /home/sk/src/matchpy/tests/test_matching.py:865:
        RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain
        merged marks which are hard to deal with correctly.
        Please use node.get_closest_marker(name) or node.iter_markers(name).
        Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
            names, values = obj.parametrize.args

    Also fix missing newline.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 96.45% when pulling 1f73aa0 on skirpichev:declarative-setup into ff8b28a on HPAC:master.

@wheerd
Copy link
Collaborator

wheerd commented Nov 15, 2018

@skirpichev What is the advantage of using setup.cfg over using the setup.py directly?

@skirpichev
Copy link
Contributor Author

More declarative config, no code at all. And all projects settings are in one place.

@wheerd wheerd merged commit 4ab3d16 into HPAC:master Nov 18, 2018
@wheerd
Copy link
Collaborator

wheerd commented Nov 18, 2018

Thank you for your contribution @skirpichev! I don't have a lot of time for this project anymore so I apologize for taking so long to get to your request. I agree with both your points about line endings and the requirements file. The version ranges are meant to prevent the package from breaking when one of the dependencies introduces breaking changes (assuming they do semantic versioning).

@skirpichev skirpichev deleted the declarative-setup branch November 18, 2018 20:27
@skirpichev
Copy link
Contributor Author

I don't have a lot of time for this project anymore

I hope this project still be alive and development will be continued. This library looks to be a promising candidate to replace current pattern matching abilities in the diofant.

I apologize for taking so long to get to your request.

I think this one wasn't so important.

I agree with both your points about line endings

I'll try to fix that.

@hbarthels
Copy link
Contributor

I hope this project still be alive and development will be continued. This library looks to be a promising candidate to replace current pattern matching abilities in the diofant.

MatchPy was developed because we need pattern matching for Linnea. As long as I'm working on Linnea, I will at least make sure that MatchPy remains in a usable state. MatchPy currently does everything I need for Linnea, so from my point of view there is nothing that urgently needs to be done.

I wouldn't mind investing more work into MatchPy, but we don't have the resources (time, contributors) right now. Any help is much appreciated.

I agree with both your points about line endings

I'll try to fix that.

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants