Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces static attribute Operation.unpacked_args_to_init #73

Merged
merged 3 commits into from Oct 29, 2021

Conversation

kaushikcfd
Copy link
Contributor

Passing unpacked args is generally helpful if the class derived from
Operation has its constructor implemented via a dataclass.

Passing unpacked args is generally helpful if the class derived from
Operation has its constructor implemented as a dataclass.
@coveralls
Copy link

coveralls commented Oct 23, 2021

Coverage Status

Coverage increased (+0.004%) to 96.449% when pulling fe05c21 on kaushikcfd:unpacked_args_to_init into 390b2d3 on HPAC:master.

@kaushikcfd
Copy link
Contributor Author

Added a regression that checks for the new feature, so the coverage should go back up. However, unsure about the performance regression, I don't think we are doing anything very expensive than what was already there.

@wheerd
Copy link
Collaborator

wheerd commented Oct 24, 2021

Looks good, the tests are failing with Python 3.6 though because of the dataclasses. @hbarthels what do you think, can we drop support for Python 3.6? I think it is close to end of life anyways.

@kaushikcfd
Copy link
Contributor Author

Looks good, the tests are failing with Python 3.6 though because of the dataclasses.

For Py3.6 CI we could add dataclasses as a requirement. Wdyt?

@kaushikcfd kaushikcfd mentioned this pull request Oct 25, 2021
4 tasks
@wheerd wheerd merged commit 45f6374 into HPAC:master Oct 29, 2021
@wheerd
Copy link
Collaborator

wheerd commented Oct 29, 2021

@kaushikcfd I merged it and created a new release. Thank you for your PR and sorry for the delay!

@hbarthels
Copy link
Contributor

Sorry for not joining this conversation earlier.

Looks good, the tests are failing with Python 3.6 though because of the dataclasses. @hbarthels what do you think, can we drop support for Python 3.6? I think it is close to end of life anyways.

Yes, I'm fine with dropping support for Python 3.6.

However, unsure about the performance regression, I don't think we are doing anything very expensive than what was already there.

I don't think this is an actual performance regression. A few times already, I observed that a test failed because it exceeded the time limit, even if there were no changes that affected the test. I suspect that those are more or less random performance fluctuations. Perhaps we should increase the time limit for all test by a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants