Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove short option -t for --theme #1571

Closed
3 tasks done
shahzebsiddiqui opened this issue Jul 21, 2023 · 0 comments · Fixed by #1576
Closed
3 tasks done

Remove short option -t for --theme #1571

shahzebsiddiqui opened this issue Jul 21, 2023 · 0 comments · Fixed by #1576
Assignees

Comments

@shahzebsiddiqui
Copy link
Member

shahzebsiddiqui commented Jul 21, 2023

The -t for --theme conflicts with sub commands specially buildtest it query --testpath. We want this option --testpath to have -t for --testpath but since -t is reserved for --theme lets not have a short option.

Let's remove the -t for --theme throughout the codebase and only use long option

See

We should do the following

  • update bash completion script and remove -t option wherever its used for --theme
  • Remove -t from documentation wherever its mentioned for --theme also check all .. command-output where its -t and replace with --theme
  • Update any docstring or comment throughout the code base
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants