Missing search_paths when using topology executable or the pytest plugin

[carlos-jenkins]

pytest plugin

Relevant lines are:

topology/lib/topology/pytest/plugin.py

Line 266 in f323846

search_paths = [

# Get a list of all testing directories
search_paths = [
    abspath(arg) for arg in config.args if isdir(arg)
]

injected_attr = parse_attribute_injection(
    injection_file,
    search_paths=search_paths
)

In this case only arguments that are directory are considered for the search path. But if we pass a single test as an argument pytest ... test/test_my.py then it will never be injected. In this case, we could also do:

search_paths = [
    abspath(arg) for arg in config.args
    if isdir(arg) else abspath(dirname(arg))
]

Executable

Relevant lines are:

topology/lib/topology/main.py

Line 62 in f323846

injection_spec = parse_attribute_injection(args.inject)

if args.inject is not None:
    injection_spec = parse_attribute_injection(args.inject)

In this case injection is basically broken unless we call the topology executable from where do we expect the root be, as the default search_paths is used (cwd).

In this case too, we could get the search path from the input:

if args.inject is not None:
    injection_spec = parse_attribute_injection(
        args.inject,
        search_paths=dirname(args.topology)
    )

What do you think?