-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/oz30 #306
Conversation
Bumps [@openzeppelin/contracts](https://github.com/OpenZeppelin/openzeppelin-contracts) from 3.0.0-rc.0 to 3.0.0-rc.1. - [Release notes](https://github.com/OpenZeppelin/openzeppelin-contracts/releases) - [Changelog](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/CHANGELOG.md) - [Commits](OpenZeppelin/openzeppelin-contracts@v3.0.0-rc.0...v3.0.0-rc.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@obernardovieira, any idea why this fails? It works locally and I updated my packages using |
The problem is around the erc165 checker, which I do not have much experience, but I've seen a couple of things.
I had exactly the same problems as the CI and after adding ERC20 constructor (from 1.) and removing the "require" in ERC20Whitelisted constructor, it worked (with one exception). I just don't know how you want to fix it.
|
Next time CI gets different results than my local machine, I should remember to remove the Once I got the errors in my machine it was easy to fix. OpenZeppelin just changed the constructor for ERC20 and renamed that function in ERC165Cheker. |
ahah that usually helps 😂 |
It took me a while to update everything to work with OpenZeppelin contracts 3.0, some tricks they threw in, including changing the ERC20 constructor signature.
I actually had to discard some 20 commits and branch from a branch to try a different approach.
And they broke one of my toys, I had to do some hard stuff to fix
Democracy.sol
:(