Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(enhance) add ability to suggest shows with same name #32

Open
ZacharyRSmith opened this issue Dec 2, 2015 · 4 comments
Open

(enhance) add ability to suggest shows with same name #32

ZacharyRSmith opened this issue Dec 2, 2015 · 4 comments

Comments

@ZacharyRSmith
Copy link
Member

Eg, try searching "sopranos"...you get 2 instances of "The Sopranos" which seem the same inasmuch as they render the same on the graph (i haven't looked at the actual JS objects yet...)

@ZacharyRSmith
Copy link
Member Author

another example: "The Office"

@ZacharyRSmith
Copy link
Member Author

#44 fixed "The Sopranos", but NOT "The Office"

@ZacharyRSmith
Copy link
Member Author

Ok, still showing 2 suggestions for "The Office" because it's showing the US and UK versions. However, whichever the end-user clicks on, the US version is shown because we're just using the show name to get graph data

...possible solution is:

// checking search suggestions for duplicates
// if dup
// make API call using OMDB to get IMDB id
(refactor getAllSeasons() to use id instead of title)

...the above would take some time, so I'll be doing a patch that just excludes shows with duplicate names

ZacharyRSmith added a commit to ZacharyRSmith/ShowPlots that referenced this issue Dec 2, 2015
@ZacharyRSmith
Copy link
Member Author

#51 patches this, but should be improved

lukebp added a commit that referenced this issue Dec 2, 2015
(patch #32) Do not suggest multiple shows of the same name
@ZacharyRSmith ZacharyRSmith changed the title (bug) search bar sometimes suggests the same thing multiple times (enhance) add ability to suggest shows with same name Dec 2, 2015
@ZacharyRSmith ZacharyRSmith removed their assignment Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant