Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please remove boost #29

Open
mikeseven opened this issue Apr 25, 2013 · 8 comments
Open

please remove boost #29

mikeseven opened this issue Apr 25, 2013 · 8 comments

Comments

@mikeseven
Copy link

boost dependency is not needed and creates some compiler issues with different versions of boost out there.

You should use C++11 directly. And please update CMakefiles to support C++11 flags for gcc.

@kknox
Copy link

kknox commented Apr 25, 2013

Hi Mike,

First, thanks for taking the time to leave feedback. Boost is not an easy dependency to get rid of, and is not work that I would categorize as high priority for us. Boost is a big reason that we are able to release Bolt on the timetable that we have, as it saved us from having to reinvent the wheel for various features. I do understand that there are a lot of developers that hate dependencies of any form, but we do try to actively mitigate the pain of managing Bolts dependencies with the cmake build system and its excellent feature of ExternalProject_Add() to download and compile all our boost dependencies at build time. Hopefully, people can live with Boost for a while longer with this support.

We document that vs10 is one of our supported compilers, so we avoid c++11 dependencies, at least in the OpenCL codepath. Our AMP codepath requires vs11, so I see no harm in using c++11 features directly in any file associated with AMP but this won't eliminate Boost from the build.

GCC support (Linux support) is still a TODO item at this time, but we did everything we could to avoid windows dependencies; one of the reasons we picked cmake as our build system.

@mikeseven
Copy link
Author

Indeed, if you require vs10, I understand you use boost.
I still think you should modify the code so to require boost for vs10 or use C++11 for more modern compilers and thus benefit from faster corresponding features in C++11. FYI, it took me 1h to make the modifs for GCC 4.8.

@kknox
Copy link

kknox commented Apr 25, 2013

Did you get Bolt to build for Linux already? I confess, i have not personally tried this yet. You may want to consider submitting this work as a pull request if you are comfortable sharing.

Was your experience building Bolt comfortable and easy? Was our documentation sufficient? You are the first I have heard of building Bolt outside of AMD!

@mikeseven
Copy link
Author

yes on linux and mac osx 10.8 with OpenCL binding.
I'm still testing and once I've cleanup the awful hacks I did, I'll create a fork and pull back.

@jayavanth
Copy link
Collaborator

Hi Mike,
How is it going? Are you looking into porting Bolt for both 32 and 64 bit? Please let us know if you have any issues, we are here to help.

@mikeseven
Copy link
Author

Hey Jay,

I didn't make much progress on bolt last week but I build on 64b desktops.

-- Mike
On May 5, 2013 10:07 PM, "Jay" notifications@github.com wrote:

Hi Mike,
How is it going? Are you looking into porting Bolt for both 32 and 64 bit?
Please let us know if you have any issues, we are here to help.


Reply to this email directly or view it on GitHubhttps://github.com//issues/29#issuecomment-17466487
.

@jayavanth
Copy link
Collaborator

That's great, 64b builds are comparatively stable. Please keep us updated on that.

@jayavanth
Copy link
Collaborator

Hi Mike, We've added support for Linux to Bolt and there's been a lot of code changes to the library. Are you able to work with Bolt on Linux?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants