Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to navbar #965

Merged
merged 3 commits into from
Jun 30, 2021
Merged

Add icons to navbar #965

merged 3 commits into from
Jun 30, 2021

Conversation

klieret
Copy link
Member

@klieret klieret commented Apr 30, 2021

Not sure about this, but I was playing around with having icons in the navbar, e.g.

image

might be a bit cluttered

@hegner
Copy link
Member

hegner commented May 28, 2021

looks quite nice!

@hegner hegner self-requested a review May 28, 2021 12:51
@hegner
Copy link
Member

hegner commented May 28, 2021

@graeme-a-stewart - what's your take on this? The code change itself is trivial

@eduardo-rodrigues
Copy link
Member

Looks good to me too 👍 .

@klieret
Copy link
Member Author

klieret commented May 28, 2021

Hi! When we were discussing this in the coordination meeting one of the recommendations was to have a bit more space between icon and text. We didn't exactly take a vote, but I got the feeling that this PR was a bit more controversial (?)

@graeme-a-stewart
Copy link
Member

Hi - thanks @klieret, I do like the idea. As @eduardo-rodrigues said I think it looks better with a little more space between the icon and the text, which I added on the last commit (I don't know if there's a better way than   but I am not a CSS person.

@graeme-a-stewart
Copy link
Member

There is one weirdness still remaining though - the bottom margin between the HSF on the LHS and the rest of the icons are now misaligned by a few pixels. Does anyone know how to fix that?

Screen Shot 2021-05-31 at 09 56 11

Copy link
Member

@graeme-a-stewart graeme-a-stewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to fix misalignment

@klieret
Copy link
Member Author

klieret commented May 31, 2021

I can take a look later this week again. Perhaps I can figure out the alignment issue

@klieret
Copy link
Member Author

klieret commented Jun 26, 2021

The issue of the misalignment is due to conflicting padding settings in hsf.css:

/* The logo */
.navbar-brand {
    height: 40px;
    padding: 12.5px 15px;
    font-size: 15px;
}

/* This is the rest of the items */
.navbar-nav > li > a {
    padding-top: 9.5px;
    padding-bottom: 9.5px;
}

let me fix that

@klieret
Copy link
Member Author

klieret commented Jun 26, 2021

Screenshot from 2021-06-26 11-45-52 png

@graeme-a-stewart graeme-a-stewart merged commit b101556 into master Jun 30, 2021
@graeme-a-stewart
Copy link
Member

Thanks @klieret - the fix is perfect 👍

@klieret klieret deleted the navbar-icons branch June 30, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants