Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi container CI setup #82

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Multi container CI setup #82

merged 1 commit into from
Aug 21, 2018

Conversation

graeme-a-stewart
Copy link
Member

This is a better setup that should allow for testing against several images in parallel, so platform coverage can be easily expanded.

@graeme-a-stewart
Copy link
Member Author

OK, I can't fathom why the CI is now not starting...

@graeme-a-stewart
Copy link
Member Author

OK, there is a bug in my yaml, here Travis reports "Could not parse .travis.yml".

Make Travis CI test two different environments, via
the "env" stanza to setup for a CentOS7 and an Ubuntu 16
containerised image.

Generalise the build script to allow for easy customisation of the
build within different images.

Add a small README to the tests area.
@graeme-a-stewart
Copy link
Member Author

@amete - ping on this review!

Copy link
Collaborator

@amete amete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!

I have a minor comment on the docker images. I wonder if it would be better to decouple these from user space and create/maintain them under a common HSF account which can be shared among different WLCG/HSF projects.

@amete amete merged commit 989cc46 into master Aug 21, 2018
@amete amete deleted the multi-ci branch August 21, 2018 08:44
@amete amete mentioned this pull request Aug 21, 2018
@graeme-a-stewart
Copy link
Member Author

Hi @amete - yes, I think you're right about the containers. We have an HSF docker account where I can upload them.

@amete
Copy link
Collaborator

amete commented Aug 21, 2018

Sounds good, thanks a lot @graeme-a-stewart :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants