Improve build #1074
Merged
Improve build #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into improve-build
…nto improve-build
…s-0.8.1' into improve-build
…6.8.0' into improve-build
…into improve-build
gmokki
reviewed
Dec 5, 2016
| @@ -43,7 +44,8 @@ function setUpStaticFolders() { | |||
| const staticFolder = path.join(process.cwd(), '_static'); | |||
| // Sert cache for 1 week | |||
| const oneDay = 86400000; | |||
| app.use(config.APP_PATH, express.static(staticFolder, { | |||
| app.use(config.APP_PATH, expressStaticGzip(staticFolder, { | |||
There was a problem hiding this comment.
The experss-static-gzip does not correctly implement the Vary header because it does not send the Vary header always for resource that has a precompressed version available.
The Vary header is only used by caching proxies and the failure case can be for example that:
- user1 fetches app.js without Accept-Encoding header (or with Accept-Encoding value that has no precompressed file such as bzip2)
- the express-static-gzip does not Vary header in response
- proxy caches the result
- user2 asks for the resource with Accept-Encoding: br, gzip
- the proxy finds the uncompressed version and serves that one (because the response did not have proper Vary)
If the uncompressed also had a Vary header the proxies would not get 'poisoned' with uncompressed versions. This is normally not a problem for internal applications, but with the wild west of internet and it's caches it would be much safer to have the header correctly implemented.
There was a problem hiding this comment.
…' into improve-build
…l-0.4.0' into improve-build
…into improve-build
…' into improve-build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is done - it:
follows the style and naming rules (passes
npm run lint)doesn't break anything (passes
npm run test-localandnpm run test-browserstack)design is as expected. NOTE! visuals are compared using HSL theme (
CONFIG=hsl npm run dev).-- If no design changes:
BS_USERNAME=user BS_ACCESS_KEY=key npm run test-visualpasses-- If design changes:
BS_USERNAME=user BS_ACCESS_KEY=key npm run test-visual-updateto generate new imagesany changed files are transformed to ES6
all new strings visible to users are
all changed components
If this PR fixes a bug, it includes a new test that catches the bug to prevent regressions.