DT-5452 Show closed stops on map using badge icons #4970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbruch
reviewed
Mar 13, 2024
app/util/mapIconUtils.js
Outdated
Comment on lines
379
to
380
| ? `icon-icon_stop-temporarily-closed-badge` | ||
| : `icon-icon_stop-closed-badge`; |
There was a problem hiding this comment.
Which mode does this stop icon represent (the sprite files does not show up in git)?
Another option to handle badges I'm currently exploring with rental stations, is having badges included in the original svg, and activate/color them via css vars. This would decouple the code from knowing where to place the badge.
There was a problem hiding this comment.
These are universal badges for any mode. Grey clock symbol / cross on red background.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Draw badges on stop icons
Stop is permanently closed when there are no NO_SERVICE alerts and there are no routes related to it
Stop is temporarily closed when alerts show NO_SERVICE
Test added for realtime stop layer
Relies on otp PR New vectortile layer for Digitransit realtime stops opentripplanner/OpenTripPlanner#5743 and DT-5452 new realtime stop layer configuration OpenTripPlanner-data-container#389
Pull Request Check List
Review