Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workplace shares are not checked #410

Open
zptro opened this issue Nov 25, 2021 · 1 comment · May be fixed by #453
Open

Workplace shares are not checked #410

zptro opened this issue Nov 25, 2021 · 1 comment · May be fixed by #453
Labels
invalid This doesn't seem right
Milestone
v5.0

Comments

@zptro
Copy link
Collaborator

zptro commented Nov 25, 2021

Service, shop, logistics and industry workplaces are in input files expressed as shares of total number of workplaces. However, we do not check that this share is less than or equal to one.
@zptro zptro added the invalid This doesn't seem right label Nov 25, 2021
@annika-wsp
Copy link
Collaborator

MAL2019 input files have some shares over 100 %, so if this is checked, I think it should produce a warning but not stop the whole process (unless the old input files are changed too).

@zptro zptro linked a pull request May 16, 2022 that will close this issue
Check that workplace shares are not larger than one #453
Open
@zptro zptro added this to the v5.0 milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
v5.0
Development

Successfully merging a pull request may close this issue.

Check that workplace shares are not larger than one HSLdevcom/helmet-model-system
2 participants
@zptro @annika-wsp