Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that workplace shares are not larger than one #453

Open
wants to merge 1 commit into
base: olusanya
Choose a base branch
from
Open

Check that workplace shares are not larger than one #453

wants to merge 1 commit into from

Conversation

zptro
Copy link
Collaborator

@zptro zptro commented May 16, 2022

This halts the model run if workplace shares larger than one are detected. As MAL 2019 data contains such anomality, we should either wait with pulling this or somehow change it into a warning.

@zptro zptro requested a review from johpiip May 16, 2022 12:59
@zptro zptro linked an issue May 16, 2022 that may be closed by this pull request
Workplace shares are not checked #410
Open
johpiip
johpiip approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@johpiip johpiip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could change log.error to log.warn here but it might deteriorate land-use data quality if people do not notice warnings.

@zptro zptro added this to the v5.0 milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johpiip johpiip johpiip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.

Workplace shares are not checked
2 participants
@zptro @johpiip