Vehicle kms and noise calculation #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zptro
commented
Mar 10, 2021
•
zptro
commented
- Sum vehicle kilometres to area level
- Calculate noise areas
- Print numbers of metro and train stations (for use in CBA maintenance cost calculation)
- Save car time matrices in Emme
added 11 commits
March 2, 2021 13:40
johpiip
requested changes
Mar 15, 2021
There was a problem hiding this comment.
Nice! I added a couple of comments regarding documentations. One other issue though... Are we still using pylint? The linter throws 215 problems in these changed files (trailing whitespace, too long lines, missing docstrings, naming conventions...). We could also do a separate PR for cleaning those here and in other scripts.
The question is rather "Are we still not using A separate PR for fixing all the bad coding is a good idea. |
johpiip
approved these changes
Mar 15, 2021
johpiip
approved these changes
Mar 16, 2021
|
@johpiip, maybe this is a better way of representing the step-wise function? |
johpiip
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.