Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CarUseModel and TourCombinationModel into own modules #477

Merged
merged 5 commits into from
Jan 13, 2023
Merged

Move CarUseModel and TourCombinationModel into own modules #477

merged 5 commits into from
Jan 13, 2023

Conversation

zptro
Copy link
Collaborator

@zptro zptro commented Nov 4, 2022

  • Move CarUseModel and TourCombinationModel into own modules
  • Improve variable naming

@zptro zptro requested a review from johpiip November 4, 2022 15:11
@johpiip
Copy link
Contributor

johpiip commented Jan 3, 2023

My apologies for returning to this so late. I have the model run running, and I will approve this by the end of the week if is shows no glitches.

@johpiip johpiip mentioned this pull request Jan 5, 2023
Merged
johpiip
johpiip approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@johpiip johpiip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results are the same as in basic 2018 model run, nice work!

@johpiip johpiip self-requested a review January 13, 2023 13:34
johpiip
johpiip approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@johpiip johpiip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged olusanya back to #477 after merging #460 to olusanya. #460 and #477 edit different files, so I don't think another model run is necessary so I will approve this.

@johpiip johpiip merged commit fd0efb1 into olusanya Jan 13, 2023
@johpiip johpiip deleted the reafactor/models branch January 13, 2023 13:38
@johpiip johpiip added this to the v4.1.2 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johpiip johpiip johpiip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zptro @johpiip